Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim

From	"Darrick J. Wong" <darrick.wong@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim
Date	2017-02-15 03:20 +0100
Message-ID	<taXmh-1AR-3@gated-at.bofh.it> (permalink)
References	<taOM2-4Ah-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 14, 2017 at 06:08:30PM +0100, Arnd Bergmann wrote:
> The length is now passed by reference, so the assertion has to be updated
> to match the other changes, as pointed out by this W=1 warning:
> 
> fs/xfs/xfs_extent_busy.c: In function 'xfs_extent_busy_trim':
> fs/xfs/xfs_extent_busy.c:356:13: error: ordered comparison of pointer with integer zero [-Werror=extra]
> 
> Fixes: ebf55872616c ("xfs: improve handling of busy extents in the low-level allocator")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied (4.11).

--D

> ---
>  fs/xfs/xfs_extent_busy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_extent_busy.c b/fs/xfs/xfs_extent_busy.c
> index ab062610234e..77760dbf0242 100644
> --- a/fs/xfs/xfs_extent_busy.c
> +++ b/fs/xfs/xfs_extent_busy.c
> @@ -353,7 +353,7 @@ xfs_extent_busy_trim(
>  	struct rb_node		*rbp;
>  	bool			ret = false;
>  
> -	ASSERT(len > 0);
> +	ASSERT(*len > 0);
>  
>  	spin_lock(&args->pag->pagb_lock);
>  restart:
> -- 
> 2.9.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xfs: fix len comparison in xfs_extent_busy_trim Arnd Bergmann <arnd@arndb.de> - 2017-02-14 18:10 +0100
  Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim Christoph Hellwig <hch@lst.de> - 2017-02-14 20:20 +0100
  Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-02-15 03:20 +0100

csiph-web