Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580669

Re: Regression in next with use printk_safe buffers in printk

Show all headers | View raw

* Sergey Senozhatsky <sergey.senozhatsky@gmail.com> [170214 08:03]:
> Hello,
> 
> Cc Rafael, just in case
> 
> On (02/13/17 10:59), Tony Lindgren wrote:
> > Looks like commit f975237b7682 ("printk: use printk_safe buffers in
> > printk") causes "possible circular locking dependency detected " for
> > me on the first suspend.
> 
> thanks for the report.
> 
> > Reverting the following four patches in next makes it go away:
> > 
> > d9c23523ed98 ("printk: drop call_console_drivers() unused param")
> > de6fcbdb68b2 ("printk: convert the rest to printk-safe")
> > 8b1742c9c207 ("printk: remove zap_locks() function")
> > f975237b7682 ("printk: use printk_safe buffers in printk")
> 
> 
> these patches basically just enable locked where it previously was
> forcibly turned off. no timekeeping/pm/sched/etc code was modified.
> can you share the link where Peter pointed out that this might be
> caused by printk() changes?

Oh sorry I should have been more specific. Not much there to share,
I got redirected over to Peter's department in a private email thread
while chasing this issue. So that was just Peter's comment looking at
the log output.

> 	timekeeping_resume()
> 		lock timekeeper_lock
> 		lock tk_core
> 			tk_debug_account_sleep_time()
> 			printk()			<< lockdep was disabled here before
> 				try_to_wake_up()
> 					lock_hrtimer_base()  ##hrtimer_bases.lock

Yeah above seems describe what changed, so your patch makes sense.

> shouldn't tk_debug_account_sleep_time() do printk_deferred() instead of
> 'normal' printk()?
> printk() calls from under timekeeping seqlock are not safe, aren't they?
> and tk_debug_account_sleep_time() is under tk_core seq lock.
> 
> IOW, replace pr_info() in tk_debug_account_sleep_time() with something
> like this
> 
> 	printk_deferred(KERN_INFO "Suspended for %lld.%03lu seconds\n",
> 			(s64)t->tv_sec, t->tv_nsec / NSEC_PER_MSEC);

Your patch below fixes the issue for me thanks. I had to apply it manually
though as tabs got replaced by spaces probably by some mail daemons.

Regards,

Tony

> ---
> 
> diff --git a/kernel/time/timekeeping_debug.c b/kernel/time/timekeeping_debug.c
> index ca9fb800336b..b8f7146c3538 100644
> --- a/kernel/time/timekeeping_debug.c
> +++ b/kernel/time/timekeeping_debug.c
> @@ -75,7 +75,8 @@ void tk_debug_account_sleep_time(struct timespec64 *t)
>         int bin = min(fls(t->tv_sec), NUM_BINS-1);
>  
>         sleep_time_bin[bin]++;
> -       pr_info("Suspended for %lld.%03lu seconds\n", (s64)t->tv_sec,
> +       printk_deferred(KERN_INFO "Suspended for %lld.%03lu seconds\n",
> +                       (s64)t->tv_sec,
>                         t->tv_nsec / NSEC_PER_MSEC);
>  }
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-13 20:10 +0100
  Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-02-14 17:10 +0100
    Re: Regression in next with use printk_safe buffers in printk Peter Zijlstra <peterz@infradead.org> - 2017-02-14 17:20 +0100
      Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-02-14 18:00 +0100
        Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-14 18:10 +0100
          Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-15 05:50 +0100
        Re: Regression in next with use printk_safe buffers in printk Peter Zijlstra <peterz@infradead.org> - 2017-02-14 19:40 +0100
          Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-15 05:50 +0100
    Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-14 18:00 +0100
    Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-15 19:10 +0100
      Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-16 02:40 +0100
        Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-16 05:10 +0100
          Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-16 05:30 +0100
            Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-16 16:20 +0100
              Re: Regression in next with use printk_safe buffers in printk Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-02-16 17:40 +0100
                Re: Regression in next with use printk_safe buffers in printk Tony Lindgren <tony@atomide.com> - 2017-02-16 20:20 +0100

csiph-web