Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580419

Re: linux-next: build failure after merge of the net tree

Show all headers | View raw

On Tue, Feb 14, 2017 at 07:42:21AM +0100, Ingo Molnar wrote:
> 
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi all,
> > 
> > After merging the net tree, today's linux-next build (powerpc64le perf)
> > failed like this:
> > 
> > Warning: tools/include/uapi/linux/bpf.h differs from kernel
> > bpf.c: In function 'bpf_prog_attach':
> > bpf.c:180:6: error: 'union bpf_attr' has no member named 'attach_flags'; did you mean 'map_flags'?
> >   attr.attach_flags  = flags;
> >       ^
> > 
> > Caused by commit
> > 
> >   7f677633379b ("bpf: introduce BPF_F_ALLOW_OVERRIDE flag")
> > 
> > Unfortunately, the perf header files are kept separate from the kernel
> > header files proper and are not automatically copied over :-(
> 
> No, that's wrong, the problem is not that headers were not shared, the problem is 
> that a tooling interdependency was not properly tested *and* that the dependency 
> was not properly implemented in the build system either.
> 
> Note that we had similar build breakages when include headers _were_ shared as 
> well, so sharing the headers would only have worked around this particular bug and 
> would have introduced fragility in other places...
> 
> The best, most robust solution in this particular case would be to fix the 
> (tooling) build system to express the dependency, that would have shown the build 
> failure right when the modification was done.

so we have the warning now:
  Warning: tools/include/uapi/linux/bpf.h differs from kernel

do you want to change it into the build failure?

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build failure after merge of the net tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-13 23:20 +0100
  Re: linux-next: build failure after merge of the net tree Ingo Molnar <mingo@kernel.org> - 2017-02-14 07:40 +0100
  Re: linux-next: build failure after merge of the net tree Ingo Molnar <mingo@kernel.org> - 2017-02-14 07:50 +0100
    Re: linux-next: build failure after merge of the net tree Jiri Olsa <jolsa@redhat.com> - 2017-02-14 10:20 +0100
      Re: linux-next: build failure after merge of the net tree Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-14 14:00 +0100
        Re: linux-next: build failure after merge of the net tree Jiri Olsa <jolsa@redhat.com> - 2017-02-14 14:30 +0100
          Re: linux-next: build failure after merge of the net tree Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-14 15:00 +0100
  Re: linux-next: build failure after merge of the net tree Joe Stringer <joe@ovn.org> - 2017-02-14 09:10 +0100
  Re: linux-next: build failure after merge of the net tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-16 04:10 +0100
    Re: linux-next: build failure after merge of the net tree David Miller <davem@davemloft.net> - 2017-02-16 04:40 +0100
      Re: linux-next: build failure after merge of the net tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-02-16 04:50 +0100

csiph-web