Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1680863

[tip:irq/urgent] genirq: Force inlining of __irq_startup_managed to prevent build failure

Show all headers | View raw

Commit-ID:  2372a519f63829b8effcdde5f4564a7e036294f0
Gitweb:     http://git.kernel.org/tip/2372a519f63829b8effcdde5f4564a7e036294f0
Author:     Geert Uytterhoeven <geert@linux-m68k.org>
AuthorDate: Tue, 4 Jul 2017 12:06:01 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 4 Jul 2017 12:36:44 +0200

genirq: Force inlining of __irq_startup_managed to prevent build failure

If CONFIG_SMP=n, and gcc (e.g. 4.1.2) decides not to inline
__irq_startup_managed(), the build fails with:

    kernel/built-in.o: In function `irq_startup':
    (.text+0x38ed8): undefined reference to `irq_set_affinity_locked'

Fix this by forcing inlining of __irq_startup_managed().

Fixes: 761ea388e8c4e3ac ("genirq: Handle managed irqs gracefully in irq_startup()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: http://lkml.kernel.org/r/1499162761-12398-1-git-send-email-geert@linux-m68k.org

---
 kernel/irq/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 2e30d925..aa5497d 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -234,7 +234,7 @@ __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 	return IRQ_STARTUP_MANAGED;
 }
 #else
-static int
+static __always_inline int
 __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 {
 	return IRQ_STARTUP_NORMAL;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-04 12:10 +0200
  [tip:irq/urgent] genirq: Force inlining of __irq_startup_managed to  prevent build failure tip-bot for Geert Uytterhoeven <tipbot@zytor.com> - 2017-07-04 12:50 +0200

csiph-web