Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1680862

Re: [PATCH] rmem: support for dma_addr different from phys_addr

Show all headers | View raw

On Tue, Jul 04, 2017 at 01:34:38PM +0300, Vladimir Kondratiev wrote:
> On some systems, dma address differs from physical one due to
> various reasons.
> 
> dma_init_coherent_memory is aware of it, it takes both
> phys_addr_t and dma_addt_t arguments for memory block.
> However, rmem_dma_device_init passes physical address for DMA one.
> 
> Fix this, using phys_to_dma(). This assumes the whole buffer has
> same offset between physical and dma addresses.
> 
> Change-Id: Ic709312941ee4e1a37afb2ea25cbd759eabc009b

What is that line for?  You didn't use checkpatch.pl :(

> Intel Israel (74) Limited
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.

Ok, this is getting really annoying, according to my lawyers, I have to
never respond to emails with this in it, and should just delete it.  But
I'll be nice, and tell you all to go fix all of Intel's email system to
never send this stuff out again, it keeps happening over and over and
over and is preventing you from contributing to open source projects.

email is now deleted.

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rmem: support for dma_addr different from phys_addr Vladimir Kondratiev <vladimir.kondratiev@intel.com> - 2017-07-04 12:40 +0200
  Re: [PATCH] rmem: support for dma_addr different from phys_addr Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-04 12:50 +0200

csiph-web