Re: [PATCH v2] sched/pelt: fix false running accounting

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] sched/pelt: fix false running accounting
Date	2017-07-04 13:10 +0200
Message-ID	<tZtSp-7sm-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <tZqrw-5a4-31@gated-at.bofh.it> <tZrxg-5SB-1@gated-at.bofh.it> <tZs9X-6kT-1@gated-at.bofh.it> <tZsD0-6u0-15@gated-at.bofh.it> <tZsMF-6xj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 04, 2017 at 11:57:12AM +0200, Vincent Guittot wrote:
> On 4 July 2017 at 11:44, Peter Zijlstra <peterz@infradead.org> wrote:

> > But but but, how can that happen? Should it not all be under the same
> > rq->lock and thus have only a single update_rq_clock() and thus be at
> > the same 'instant' ?
> 
> idle_balance() unlock rq->lock before calling  update_blocked_averages
> And update_blocked_averages() starts by calling update_rq_clock()

Ah indeed. Might want to clarify that point.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] sched/pelt: fix false running accounting Peter Zijlstra <peterz@infradead.org> - 2017-07-04 09:30 +0200
  Re: [PATCH v2] sched/pelt: fix false running accounting Vincent Guittot <vincent.guittot@linaro.org> - 2017-07-04 09:40 +0200
  Re: [PATCH v2] sched/pelt: fix false running accounting Peter Zijlstra <peterz@infradead.org> - 2017-07-04 10:40 +0200
    Re: [PATCH v2] sched/pelt: fix false running accounting Vincent Guittot <vincent.guittot@linaro.org> - 2017-07-04 11:20 +0200
      Re: [PATCH v2] sched/pelt: fix false running accounting Peter Zijlstra <peterz@infradead.org> - 2017-07-04 11:50 +0200
        Re: [PATCH v2] sched/pelt: fix false running accounting Vincent Guittot <vincent.guittot@linaro.org> - 2017-07-04 12:00 +0200
          Re: [PATCH v2] sched/pelt: fix false running accounting Peter Zijlstra <peterz@infradead.org> - 2017-07-04 13:10 +0200

csiph-web