[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jaya Durga <rjdurga@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation
Date	Tue, 04 Jul 2017 08:10:01 +0200
Message-ID	<tZpc5-4eb-9@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Ht8B3Npvyz+53s9WxIphd7oAWz8accRY8LCM1qAhM1o=; b=g9tmF2iC6tJsGYe/eGAsWOaLgUEx6e3bGAU01fVkCsduKX//D6lMDkKRS2B5LLNNAw fiaeBIazedNzl0Bq1CHwdJ4UXzDiFXt/zBy2T7B0+dktp+YyePv8dycVz8C4i4gLAzaP b1tvLfH0FX/o65fssArpv28JzRGjkkJQfbefRc+GLBJDXpF74G28vlQN0yN2ie3CsoXg 7pSVpOHmeAiivJvl8ot1gipvU3pa4zJCRQh6GPBZDrSqIuDLIO0SNBV2qR7We0CNtman 0hmxHZmpRE5LR8AsYa1WWprnG0bRy+Tl10DVUrDB3g/Jt3AyNtyLbKkC3nUJs4ABK2Bt VqkQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ht8B3Npvyz+53s9WxIphd7oAWz8accRY8LCM1qAhM1o=; b=qRiZbm+LqJRMdXHcQy/x5V3wMpoWzzkqZPZ/LRbEW+Uqp5oeKM9XJhsq8ul2PBiIx2 v8daLrweAKm8In7D0JFzixpFCefVqZEU2tGl8wfcdYp5GsdVKVZE0oldmJEjSvz0Igwi 5+GEGT7u+1MvYuhhs29h6k9yILgqEJlIF/bnRdoMsVKXZ8EaX1ajhqLsj+o1oJjIe3Q6 TkiJRjOHEpnRLj52HX66a10gBD5FBJSzYNfGBCTT/5Mm/+r0Dct8aD3S4UnRzFNpjgCZ 5SIeo32cTd0h1rxoeWLQrPkcEnn1oKO0eUZ2zgwvsxbLCQojeO0c9y5D4vcMFtP3w72T 9xpQ==
X-Gm-Message-State	AIVw1108g+q76AyM+b+NJ8yV39+aJU+yi+ISVaoLNB+/xseswkp1rU9T QDTxImYHttPhlg==
X-Received	by 10.36.60.150 with SMTP id m144mr12409213ita.105.1499148369728; Mon, 03 Jul 2017 23:06:09 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, rvarsha016@gmail.com, julia.lawall@lip6.fr, binoy.jayan@linaro.org, arnd@arndb.de, louie.lu@hopebaytech.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Jaya Durga <rjdurga@gmail.com>
X-Original-Date	Tue, 4 Jul 2017 11:31:15 +0530
X-Original-Message-ID	<1499148075-31280-1-git-send-email-rjdurga@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1680671

Show key headers only | View raw

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.

Signed-off-by: Jaya Durga <rjdurga@gmail.com>
---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
  */
 static int wifi_test;
 
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
 module_param(wifi_test, int, 0644);
 module_param(initmac, charp, 0644);
 module_param(video_mode, int, 0644);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga <rjdurga@gmail.com> - 2017-07-04 08:10 +0200
  Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission  representation Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 19:10 +0200

csiph-web