Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680671 > unrolled thread
| Started by | Jaya Durga <rjdurga@gmail.com> |
|---|---|
| First post | 2017-07-04 08:10 +0200 |
| Last post | 2017-07-11 19:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga <rjdurga@gmail.com> - 2017-07-04 08:10 +0200
Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 19:10 +0200
| From | Jaya Durga <rjdurga@gmail.com> |
|---|---|
| Date | 2017-07-04 08:10 +0200 |
| Subject | [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation |
| Message-ID | <tZpc5-4eb-9@gated-at.bofh.it> |
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Jaya Durga <rjdurga@gmail.com> --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 8836b31..e698f6e 100644 --- a/drivers/staging/rtl8712/os_intfs.c +++ b/drivers/staging/rtl8712/os_intfs.c @@ -93,7 +93,7 @@ */ static int wifi_test; -module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR); +module_param_string(ifname, ifname, sizeof(ifname), 0644); module_param(wifi_test, int, 0644); module_param(initmac, charp, 0644); module_param(video_mode, int, 0644); -- 1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-11 19:10 +0200 |
| Subject | Re: [PATCH 2/6] Staging: rtl8712 : os_intfs.c: use octal permission representation |
| Message-ID | <u26PE-56j-35@gated-at.bofh.it> |
| In reply to | #1680671 |
On Tue, Jul 04, 2017 at 11:31:15AM +0530, Jaya Durga wrote: > Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > > Signed-off-by: Jaya Durga <rjdurga@gmail.com> > --- > drivers/staging/rtl8712/os_intfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Did something change from the previous version of this patch? If so, what? And again, where are the rest of the patches in this series? thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web