Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number
Date	2017-07-05 22:30 +0200
Message-ID	<tZZ5U-2Lm-9@gated-at.bofh.it> (permalink)
References	<tLIxX-34o-3@gated-at.bofh.it> <tZPgd-4Af-9@gated-at.bofh.it> <tZYjv-2dl-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wednesday 05 July 2017 21:30:35 David Airlie wrote:
> ----- Original Message -----
> 
> > From: "Pali Rohár" <pali.rohar@gmail.com>
> > To: "Chun-Yi Lee" <jlee@suse.com>, "Corentin Chary"
> > <corentin.chary@gmail.com>, acpi4asus-user@lists.sourceforge.net,
> > "Dave Airlie" <airlied@redhat.com>, "Oleksij Rempel"
> > <linux@rempel-privat.de>, "João Paulo Rechi Vita"
> > <jprvita@gmail.com>
> > Cc: "Darren Hart" <dvhart@infradead.org>, "Andy Shevchenko"
> > <andy@infradead.org>, "Andy Lutomirski" <luto@kernel.org>,
> > platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
> > Sent: Wednesday, 5 July, 2017 7:51:13 PM
> > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method
> > instance number
> > 
> > On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
> > > > So problematic drivers which use instance=1 without any comments
> > > > are:
> > > >   acer-wmi
> > > >   asus-wmi
> > > >   mxm-wmi
> > > 
> > > Adding authors & maintainers of those drivers in loop.
> > 
> > Hi!
> > 
> > Dell drivers and acer-wmi are fixed now. So only asus-wmi and
> > mxm-wmi needs to be investigated.
> > 
> > Adding more people who developed those drivers recently in loop.
> > Can you check if instance number is used correctly or not?
> 
> I've no memory of why I picked 1 or 0, I probably cut-n-paste it from
> somewhere else.
> 
> Dave.

And do you have at least ACPI DSDT dumps from that machine? Or are you 
able to find some?

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number Pali Rohár <pali.rohar@gmail.com> - 2017-07-05 12:00 +0200
  Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance  number David Airlie <airlied@redhat.com> - 2017-07-05 21:40 +0200
    Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-07-05 22:30 +0200

csiph-web