Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus
Date	2017-07-05 22:30 +0200
Message-ID	<tZZ5U-2Lm-7@gated-at.bofh.it> (permalink)
References	<tYa5r-1ah-1@gated-at.bofh.it> <tYa5s-1ah-25@gated-at.bofh.it> <tZ5Gq-7vd-27@gated-at.bofh.it> <tZBPY-4mq-11@gated-at.bofh.it> <tZCsF-4Pa-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Takashi Iwai <tiwai@suse.de> writes:

> On Tue, 04 Jul 2017 21:37:48 +0200,
> Robert Jarzmik wrote:
>> 
>> Takashi Iwai <tiwai@suse.de> writes:
>> 
>> > On Fri, 30 Jun 2017 21:43:58 +0200,
>> > Robert Jarzmik wrote:
>> >> +static struct bus_type ac97_bus_type = {
>> >> +	.name		= "ac97",
>> >
>> > Name-conflict with the old ac97 bus?
>> Yeah, fair point. So what should I choose for this new one ?
>>  - ac97new
>>  - ac97bis
>>  - ac97_2
>>  - ac97reborn
>
> ac97bus
> ac97_episode_5
> ac98
> ...
>
> I have no opinion on it.
Ah clone wars one is really tempting :)
But let's have ac97bus actually.

> You can use subsys_init() for modules, it's no problem.
> When it's built for a module, all xxx_init() is handled as equivalent
> with module_init().  See linux/module.h.
>
> It's just the lack of module_exit() in your case.
Got it, I'll add it for v4.

Cheers.

-- 
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2017-07-04 21:40 +0200
  Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus Takashi Iwai <tiwai@suse.de> - 2017-07-04 22:20 +0200
    Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2017-07-05 22:30 +0200

csiph-web