Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1681697

Re: [PATCH] brcmnand: Fix up the flash cache register offset for older controllers

From Brian Norris <computersforpeace@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] brcmnand: Fix up the flash cache register offset for older controllers
Date 2017-07-05 20:20 +0200
Message-ID <tZX46-1jQ-11@gated-at.bofh.it> (permalink)
References <tZWB4-Ve-23@gated-at.bofh.it> <tZX46-1jQ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Ha, I was in the middle of writing essentially this :)

On Wed, Jul 05, 2017 at 11:15:01AM -0700, Florian Fainelli wrote:
> On 07/05/2017 10:46 AM, Karl Beldan wrote:
> > From: Karl Beldan <karl.beldan-ext@sagemcom.com>
> > 
> > Tested on BCM{63138,6838,63268} and cross checked with the various
> > *_map_part.h which the brcmnand_regs_v* in brcmnand.c have historically
> > been derived from.
> 
> BCM63138 is using a 7.0 controller, 6838 uses a 5.0 controller, but has
> a separate flash cache register which does indeed end up at 0x400 bytes
> off the main FLASH block, and finally 63268 does have a v4.0 controller
> and the flash cache is also in a separate register that makes it end up
> at 0x400.

The joy of arbitrarily-changing IP, since of course business units
within a company (or even divisions within the same business unit) would
never want to share software...

> Your change, as proposed would break chips like 7425 which use 5.0
> controller with the flash cache at 0x200 bytes.
> 
> The binding describes an optional flash-cache register cell that you can
> specify, so that's probably what you want to do here?

What he said ^^^

The "nand-cache" register range sounds like what you're looking for.

Brian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] brcmnand: Fix up the flash cache register offset for older controllers Karl Beldan <karl.beldan@gmail.com> - 2017-07-05 19:50 +0200
  Re: [PATCH] brcmnand: Fix up the flash cache register offset for  older controllers Florian Fainelli <f.fainelli@gmail.com> - 2017-07-05 20:20 +0200
    Re: [PATCH] brcmnand: Fix up the flash cache register offset for  older controllers Brian Norris <computersforpeace@gmail.com> - 2017-07-05 20:20 +0200
    Re: [PATCH] brcmnand: Fix up the flash cache register offset for  older controllers Karl Beldan <karl.beldan@gmail.com> - 2017-07-05 23:00 +0200

csiph-web