Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681315

Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates

Show key headers only | View raw

>  
> +	if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)
> +		i2s_dai_data = of_device_get_match_data(&pdev->dev);
> +	else
> +		i2s_dai_data = (struct samsung_i2s_dai_data *)
> +				platform_get_device_id(pdev)->driver_data;
> +

BTW, as we discussed together already, you are duplicating some
code here and it looks ugly. Please refactor.

Thanks,
Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: samsung: i2s: Supported high resolution rates Jaechul Lee <jcsing.lee@samsung.com> - 2017-07-05 08:00 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Andi Shyti <andi.shyti@samsung.com> - 2017-07-05 08:20 +0200
    Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Mark Brown <broonie@kernel.org> - 2017-07-05 12:20 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Andi Shyti <andi.shyti@samsung.com> - 2017-07-05 09:00 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Chanwoo Choi <cw00.choi@samsung.com> - 2017-07-06 03:00 +0200

csiph-web