Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681300

Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates

Show all headers | View raw

Hi Jaechul,

> This driver can support more frequencies over 96KHz. There are no reasons
> to limit the frequency range below 96KHz. If codecs/amps or something else
> can't support high resolution rates, the constraints would be set rates
> properly because each drivers have its own limits.

That's a good commit introduction, but you are not explaining
what you actually did. Please explain better how you fixed the
issue.

"> Supported high resolution rates"

In the patch title, please use the imperative form, not
"supported" but "support".

> +	if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)

I do not like drivers to check the Kernel's configuration, I
think just checking "pdev->dev.of_node" is enough.

The rest looks good.

Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: samsung: i2s: Supported high resolution rates Jaechul Lee <jcsing.lee@samsung.com> - 2017-07-05 08:00 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Andi Shyti <andi.shyti@samsung.com> - 2017-07-05 08:20 +0200
    Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Mark Brown <broonie@kernel.org> - 2017-07-05 12:20 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Andi Shyti <andi.shyti@samsung.com> - 2017-07-05 09:00 +0200
  Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates Chanwoo Choi <cw00.choi@samsung.com> - 2017-07-06 03:00 +0200

csiph-web