[PATCH] Staging: android/ion: fix sparse warnings

Path	csiph.com!aioe.org!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Joseph Wright <rjosephwright@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Staging: android/ion: fix sparse warnings
Date	Wed, 05 Jul 2017 03:50:06 +0200
Message-ID	<tZHC5-7VG-5@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=YXfxmY+jWFX4dS6YyRUp6HAZwdrBJ2ffg5ASIajM+n4=; b=Xzg3TtOkOVAbw8Dk93oZ8Myh1WteroykQ8x1idM/SQNW6FSSnE+c6heVM3pmQiag+H Q9DnYH9ssC4S1j/WzkvmhOslAOoNz0qadUCqweAnPS7P8SijntacQ+QBQTI/3RbrnG0Q jWNzAXa0uuZW3TgvcGgqK+vwucFQ8NMgFOseAVFNOVTbiQanfh/+T6HgMYB5IuMEauTt JSzIz9bS9c01O6oE89WjJI+Jv76bLY2Bj4+2zeBwNlbmt+ydfknRyLZ0LgPbrcWkBbyh 2+qwdcvFBoVjPAkO1zffRF+1PhHEo9abs62/ekx/wyuiZfRNCJ7AYNURLd9fmKUNa+XI t30Q==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YXfxmY+jWFX4dS6YyRUp6HAZwdrBJ2ffg5ASIajM+n4=; b=toN3dXF2YHfNhiltC5ACmoh8h7md9kdRtMh3p7jgNw4Z/GJWff5jD3u9k2neO/gonx dYzEW+AF+FFPCq7pIhg25NfmpCXFig6J6nPaVzZwWXujTcrkwhrYYNt2GpSjNVp8xzo9 slLRYJ7ty2L25AjFF8fyL8IdnNPi28RTpRy+HC9w/vNgEvu+GzR9z0Xa9lDM7/LXQcNr kymi7WoLymgO7KLoig+jytJdvBUjQQ38wo+nPg3vI88U+lvDnXrlqWEOnMhb9J4dnWHS T/XmoFoPpVunwv1uesd+N0HdvpR4AQtiE/IcSyIngNFLf5Ya9ya3duEwtwxJS+P+6KdT M9gA==
X-Gm-Message-State	AKS2vOzhGYM2CIFYXgX6BcyUdkL1MZSHlBG5qjNlRmjPjcz6ITQU6Tj2 hmIC0FG1ill7OA==
X-Received	by 10.129.73.195 with SMTP id w186mr32279227ywa.146.1499218818526; Tue, 04 Jul 2017 18:40:18 -0700 (PDT)
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joseph Wright <rjosephwright@gmail.com>
X-Original-Date	Wed, 5 Jul 2017 00:12:24 +0000
X-Original-Message-ID	<20170705001224.13213-1-rjosephwright@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1681239

Show key headers only | View raw

ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
	was not declared. Should it be static?
ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
	was not declared. Should it be static?
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
	was not declared. Should it be static?

Signed-off-by: Joseph Wright <rjosephwright@gmail.com>
---
 drivers/staging/android/ion/ion.h          | 4 ++++
 drivers/staging/android/ion/ion_cma_heap.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index fa9ed81..fda1e91 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -358,4 +358,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
 
 int ion_query_heaps(struct ion_heap_query *query);
 
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+
 #endif /* _ION_H */
diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
 	return &cma_heap->heap;
 }
 
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
 {
 	struct ion_heap *heap;
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: android/ion: fix sparse warnings Joseph Wright <rjosephwright@gmail.com> - 2017-07-05 03:50 +0200
  Re: [PATCH] Staging: android/ion: fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 20:10 +0200

csiph-web