Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
Date	Mon, 03 Jul 2017 07:10:02 +0200
Message-ID	<tZ1Mu-4SF-5@gated-at.bofh.it> (permalink)
References	<tY5p8-6GC-15@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.40,301,1496127600"; d="scan'208";a="874189094"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	dmaengine@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, Dan Williams <dan.j.williams@intel.com>, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 3 Jul 2017 10:40:22 +0530
X-Original-Message-ID	<20170703051022.GZ19154@localhost>
X-Original-References	<1498833785-22632-1-git-send-email-okaya@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1679642

Show key headers only | View raw

On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
> 
> The DMA Engine document clearly states this.
> 
> "dmaengine_submit() will not start the DMA operation".
> 
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
> 
> A descriptor goes through these transitions now.
> 
> free->prepared->queued->active->completed->free
> 
> as opposed to
> 
> free->prepared->active->completed->free

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] dmaengine: qcom_hidma: correct API violation for submit Sinan Kaya <okaya@codeaurora.org> - 2017-06-30 16:50 +0200
  Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for  submit Vinod Koul <vinod.koul@intel.com> - 2017-07-03 07:10 +0200

csiph-web