Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for submit
Date	2017-07-03 07:10 +0200
Message-ID	<tZ1Mu-4SF-5@gated-at.bofh.it> (permalink)
References	<tY5p8-6GC-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 30, 2017 at 10:43:05AM -0400, Sinan Kaya wrote:
> Current code is violating the DMA Engine API by putting the submitted
> requests directly into the HW queue. This causes queued transactions
> to be started by another thread as soon as the first one finishes.
> 
> The DMA Engine document clearly states this.
> 
> "dmaengine_submit() will not start the DMA operation".
> 
> Move HW queuing of the requests into the issue_pending() routine
> to comply with API requirements also create a new queued state for
> temporarily holding the requests.
> 
> A descriptor goes through these transitions now.
> 
> free->prepared->queued->active->completed->free
> 
> as opposed to
> 
> free->prepared->active->completed->free

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] dmaengine: qcom_hidma: correct API violation for submit Sinan Kaya <okaya@codeaurora.org> - 2017-06-30 16:50 +0200
  Re: [PATCH V2] dmaengine: qcom_hidma: correct API violation for  submit Vinod Koul <vinod.koul@intel.com> - 2017-07-03 07:10 +0200

csiph-web