Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1679405

Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning
Date 2017-07-01 23:20 +0200
Message-ID <tYxY5-aB-1@gated-at.bofh.it> (permalink)
References <tY6Oe-7ID-3@gated-at.bofh.it> <tY6Oe-7ID-13@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Arnd,

> When NVMe support is disabled, we get a couple of harmless warnings:
>
> drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: 'qla_nvme_unregister_remote_port' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:634:13: error: 'qla_nvme_abort_all' defined but not used [-Werror=unused-function]
> drivers/scsi/qla2xxx/qla_nvme.c:604:12: error: 'qla_nvme_wait_on_rport_del' defined but not used [-Werror=unused-function]
>
> This replaces the preprocessor checks in the code with equivalent
> compiler conditionals, which lets gcc drop the unused functions
> without warning, and is nicer to read.

Applied to 4.13/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap Arnd Bergmann <arnd@arndb.de> - 2017-06-30 18:20 +0200
  [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning Arnd Bergmann <arnd@arndb.de> - 2017-06-30 18:20 +0200
    Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-07-01 02:00 +0200
    Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-07-01 23:20 +0200
  Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap James Bottomley <jejb@linux.vnet.ibm.com> - 2017-06-30 18:50 +0200
    Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-06-30 19:10 +0200

csiph-web