Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678998

Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap

Show all headers | View raw

> On Jun 30, 2017, at 9:41 AM, James Bottomley <jejb@linux.vnet.ibm.com> wrote:
> 
> On Fri, 2017-06-30 at 18:10 +0200, Arnd Bergmann wrote:
>> cont_pkt->entry_type is an 8-bit field, so doing a 32-bit byteswap
>> on it will store incorrect data:
>> 
>> drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq':
>> include/uapi/linux/byteorder/big_endian.h:32:26: error: large integer
>> implicitly truncated to unsigned type [-Werror=overflow]
>> drivers/scsi/qla2xxx/qla_nvme.c:444:27: note: in expansion of macro
>> 'cpu_to_le32'
>>     cont_pkt->entry_type = cpu_to_le32(CONTINUE_A64_TYPE);
>> 
>> This removes the erroneous cpu_to_le32().
>> 
>> Fixes: e84067d74301 ("scsi: qla2xxx: Add FC-NVMe F/W initialization
>> and transport registration")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c
>> b/drivers/scsi/qla2xxx/qla_nvme.c
>> index 1da8fa8f641d..14e25e32e622 100644
>> --- a/drivers/scsi/qla2xxx/qla_nvme.c
>> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
>> @@ -441,7 +441,7 @@ static int qla2x00_start_nvme_mq(srb_t *sp)
>>  				req->ring_ptr++;
>>  			}
>>  			cont_pkt = (cont_a64_entry_t *)req-
>>> ring_ptr;
>> -			cont_pkt->entry_type =
>> cpu_to_le32(CONTINUE_A64_TYPE);
>> +			cont_pkt->entry_type = CONTINUE_A64_TYPE;
>>  
> 
> We already have a patch proposed for this, but I think it may be wrong
> (it's the same as yours, so yours may be wrong too) see the handling in
> qla_iocb.c
> 
> James

I will send patch which has correct usage in qla_iocb.c shortly. 

Thanks,
- Himanshu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap Arnd Bergmann <arnd@arndb.de> - 2017-06-30 18:20 +0200
  [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning Arnd Bergmann <arnd@arndb.de> - 2017-06-30 18:20 +0200
    Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-07-01 02:00 +0200
    Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-07-01 23:20 +0200
  Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap James Bottomley <jejb@linux.vnet.ibm.com> - 2017-06-30 18:50 +0200
    Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-06-30 19:10 +0200

csiph-web