Re: [RFC] tracing: Add support for critical section event tracing

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Joel Fernandes <joelaf@google.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] tracing: Add support for critical section event tracing
Date	Sat, 01 Jul 2017 01:30:01 +0200
Message-ID	<tYdwl-3rt-5@gated-at.bofh.it> (permalink)
References	<tvjay-y7-13@gated-at.bofh.it> <tXWvw-1aa-7@gated-at.bofh.it> <tY3nk-5u2-13@gated-at.bofh.it>
X-Original-To	Steven Rostedt <rostedt@goodmis.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gUQpH6uwbGVNz7+dZ0xGJ6ovxGLjsNFrCDziqDq0RRs=; b=Zy3NbAALT2w/bwZGAnHMr32vCNs1DV58+rLRrZ0PJIkeoX08X4agiQty4n91434Lin MqMEWIuKdnZF5xYgd4YMkARE+hbyVLcdZIIaNKglresPsv3UGsjS+E74mA/rU1bFYT7w /niRPim3vCws+wKjV5NVavzIVV7lGz5x8T82hBVJunug4v74i60lNYXlZ4HTHY1SyG1/ mgJ9dNKhj4oMNQvyNliIZF6sA0OL5UvJdw3Kpgmw4cOhsDeE8IddFJWD29HHcFg6Q3iV kA/DZXNZm12Cf7bBFpPe+Ubm9XFzSZJ2QSnyEqtxvwWl6x0Q0QCcsi3dll0poHPVvwqm JVpQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gUQpH6uwbGVNz7+dZ0xGJ6ovxGLjsNFrCDziqDq0RRs=; b=oQE07B04zCXg2gK1mUOg05Cu17YaLtwVxdpgfY2LhTUorhsQhdEKd9u3mLjmq5VtHu SCOfU9yyMhCawKNZP+BcNo6Tyff9xcjmRlt8s+zn9eHoC16+uElDYbXjsA2hpBXg7SJC QOzahXLe15faVnDwNcCmn4G0oZzZ5cEyUEgVbJKSL5M0XP1xckDZMDA/4/U4bQmy+wPt w4Cl0mzcZcj+DTRZ9YwqVzjYpmwh3XGTHZVtLAhIK9Dm/pFhXIiqvrMSDGUL8rV3frKd jfVDzOGhbhPK7XkMScw3F/pLgjO81TzwB3OcIfMSGGYvAUZEDYXhCC4+pi6rbmD4Vvve U1ig==
X-Gm-Message-State	AKS2vOzbVTBOKDL+b5hXeyV5kLbJmVpIeH3fpG43/xzrTLBj7WqDdqXw 063JVzs5TBBisjEBRRu6nR6JNPkFhyS6Us8=
X-Received	by 10.202.106.6 with SMTP id f6mr12638407oic.85.1498864896824; Fri, 30 Jun 2017 16:21:36 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 30 Jun 2017 16:21:36 -0700
X-Original-Message-ID	<CAJWu+orKc3i4BWrZEjTpVysArNAD4S-nJFKqJyeduTWCRHTX6g@mail.gmail.com>
X-Original-References	<20170412053851.26286-1-joelaf@google.com> <CAJWu+optDS1W8rS2GxvKE-GfCH5-VwZ_4eONxVJhTJrp=y7bnA@mail.gmail.com> <20170630083252.55c390a6@gandalf.local.home>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1679212

Show key headers only | View raw

Hi Steven,

On Jun 30, 2017 5:32 AM, "Steven Rostedt" <rostedt@goodmis.org> wrote:
[..]
>> Did you have any comments about this patch? It was sent a while ago
>> and if you can provide me your initial thoughts on it, I would
>> appreciate it. (Sorry to ping you about it during the busy merge
>> window time, but I was thinking if I can get any initial early
>> comments from you then I can get to work on it and finish in time well
>> before the next merge window).

> Sorry for missing that. It's still in my INBOX in the "to look at"
> markings ;-)

Cool, no problem :-)

> Actually, have you seen Tom Zanussi's patch series about histograms.
> "tracing: Inter-event (e.g. latency) support". He just recently posted
> another series.

I was at his talk during ELC. I will take a look at his new patches as
well today. Its quite a big series ;-)

> I'd like to get that in before looking at adding events into the
> critical sections. But that said, I'll still take a look at your patch.

I feel though that the inter event stuff is a bit independent of the
critical events. Other than the fact that the irqsoff tracer can
possibly be rewritten to use inter-events, I didn't see how the
critical events work depends on the inter event stuff, or blocks it as
such. Just checking if there is another reason that you see it can
conflict?

> Thanks for reminding me.

Thanks for making time for the review :-)

Regards,
Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC] tracing: Add support for critical section event tracing Joel Fernandes <joelaf@google.com> - 2017-06-30 07:20 +0200
  Re: [RFC] tracing: Add support for critical section event tracing Steven Rostedt <rostedt@goodmis.org> - 2017-06-30 14:40 +0200
    Re: [RFC] tracing: Add support for critical section event tracing Joel Fernandes <joelaf@google.com> - 2017-07-01 01:30 +0200

csiph-web