Re: [RFC] tracing: Add support for critical section event tracing

From	Joel Fernandes <joelaf@google.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] tracing: Add support for critical section event tracing
Date	2017-07-01 01:30 +0200
Message-ID	<tYdwl-3rt-5@gated-at.bofh.it> (permalink)
References	<tvjay-y7-13@gated-at.bofh.it> <tXWvw-1aa-7@gated-at.bofh.it> <tY3nk-5u2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Steven,

On Jun 30, 2017 5:32 AM, "Steven Rostedt" <rostedt@goodmis.org> wrote:
[..]
>> Did you have any comments about this patch? It was sent a while ago
>> and if you can provide me your initial thoughts on it, I would
>> appreciate it. (Sorry to ping you about it during the busy merge
>> window time, but I was thinking if I can get any initial early
>> comments from you then I can get to work on it and finish in time well
>> before the next merge window).

> Sorry for missing that. It's still in my INBOX in the "to look at"
> markings ;-)

Cool, no problem :-)

> Actually, have you seen Tom Zanussi's patch series about histograms.
> "tracing: Inter-event (e.g. latency) support". He just recently posted
> another series.

I was at his talk during ELC. I will take a look at his new patches as
well today. Its quite a big series ;-)

> I'd like to get that in before looking at adding events into the
> critical sections. But that said, I'll still take a look at your patch.

I feel though that the inter event stuff is a bit independent of the
critical events. Other than the fact that the irqsoff tracer can
possibly be rewritten to use inter-events, I didn't see how the
critical events work depends on the inter event stuff, or blocks it as
such. Just checking if there is another reason that you see it can
conflict?

> Thanks for reminding me.

Thanks for making time for the review :-)

Regards,
Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC] tracing: Add support for critical section event tracing Joel Fernandes <joelaf@google.com> - 2017-06-30 07:20 +0200
  Re: [RFC] tracing: Add support for critical section event tracing Steven Rostedt <rostedt@goodmis.org> - 2017-06-30 14:40 +0200
    Re: [RFC] tracing: Add support for critical section event tracing Joel Fernandes <joelaf@google.com> - 2017-07-01 01:30 +0200

csiph-web