[PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()

From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe()
Date	2017-06-30 22:20 +0200
Message-ID	<tYayt-1z6-7@gated-at.bofh.it> (permalink)
References	<tYayt-1z6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

platform_get_irq() returns an error code, but the intel_hdmi_audio
driver ignores it and always returns -ENODEV. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly. Also,
notice that platform_get_irq() no longer returns 0 on error.

Print error message and propagate the return value of platform_get_irq
on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
 Fix error in commit message.

 sound/x86/intel_hdmi_audio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index c19efc9..a095150 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
 	/* get resources */
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "Could not get irq resource\n");
-		return -ENODEV;
+		dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq);
+		return irq;
 	}
 
 	res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:20 +0200
  Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Takashi Iwai <tiwai@suse.de> - 2017-06-30 22:30 +0200
    Re: [PATCH v2] ALSA: x86: fix error return code in  hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:40 +0200
      Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Takashi Iwai <tiwai@suse.de> - 2017-06-30 22:40 +0200
        Re: [PATCH v2] ALSA: x86: fix error return code in  hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:50 +0200

csiph-web