Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679114
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() |
| Date | 2017-06-30 22:30 +0200 |
| Message-ID | <tYaI9-1Ck-7@gated-at.bofh.it> (permalink) |
| References | <tYayt-1z6-9@gated-at.bofh.it> <tYayt-1z6-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 30 Jun 2017 22:18:41 +0200,
Gustavo A. R. Silva wrote:
>
> Also,
> notice that platform_get_irq() no longer returns 0 on error.
There is no change by your patch in this regard, right?
Takashi
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
> Fix error in commit message.
>
> sound/x86/intel_hdmi_audio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index c19efc9..a095150 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
> /* get resources */
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "Could not get irq resource\n");
> - return -ENODEV;
> + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq);
> + return irq;
> }
>
> res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.5.0
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:20 +0200
Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Takashi Iwai <tiwai@suse.de> - 2017-06-30 22:30 +0200
Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:40 +0200
Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() Takashi Iwai <tiwai@suse.de> - 2017-06-30 22:40 +0200
Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 22:50 +0200
csiph-web