Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path
Date	2017-07-02 20:00 +0200
Message-ID	<tYRk5-5lI-11@gated-at.bofh.it> (permalink)
References	<tYqWB-3QG-3@gated-at.bofh.it> <tYqWD-3QG-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 01, 2017 at 09:40:03AM -0400, Zi Yan wrote:
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1302,6 +1302,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>  	bool ret = true;
>  	enum ttu_flags flags = (enum ttu_flags)arg;
>  
> +
>  	/* munlock has nothing to gain from examining un-locked vmas */
>  	if ((flags & TTU_MUNLOCK) && !(vma->vm_flags & VM_LOCKED))
>  		return true;

With exception of this useless hunk, looks good to me

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Thread

[PATCH v8 00/10] mm: page migration enhancement for thp Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
  [PATCH v8 06/10] mm: thp: check pmd migration entry in common path Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
    Re: [PATCH v8 06/10] mm: thp: check pmd migration entry in common  path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-07-14 11:40 +0200
      Re: [PATCH v8 06/10] mm: thp: check pmd migration entry in common  path "Zi Yan" <zi.yan@sent.com> - 2017-07-14 20:30 +0200
  [PATCH v8 09/10] mm: migrate: move_pages() supports thp migration Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
  [PATCH v8 01/10] mm: mempolicy: add queue_pages_required() Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
  [PATCH v8 08/10] mm: mempolicy: mbind and migrate_pages support thp migration Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
  [PATCH v8 04/10] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
  [PATCH v8 05/10] mm: thp: enable thp migration in generic path Zi Yan <zi.yan@sent.com> - 2017-07-01 15:50 +0200
    Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-07-02 20:00 +0200
      Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path "Zi Yan" <zi.yan@sent.com> - 2017-07-03 03:30 +0200
    Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-07-11 09:00 +0200
      Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-07-13 11:40 +0200
        Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-07-14 02:10 +0200

csiph-web