Re: [PATCH] pinctrl: rza1: fix incorrect failure check on platform_get_resources

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: rza1: fix incorrect failure check on platform_get_resources
Date	2017-06-30 16:00 +0200
Message-ID	<tY4CL-6b8-33@gated-at.bofh.it> (permalink)
References	<tY1vc-4jV-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 30, 2017 at 12:33 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The return res from platform_get_resources should be checked for
> a failure rather than ret.  Fixes warning:
>
> 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Geert already sent the right fix for this.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: rza1: fix incorrect failure check on platform_get_resources Colin King <colin.king@canonical.com> - 2017-06-30 12:40 +0200
  Re: [PATCH] pinctrl: rza1: fix incorrect failure check on platform_get_resources Linus Walleij <linus.walleij@linaro.org> - 2017-06-30 16:00 +0200

csiph-web