Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678851
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management |
| Date | 2017-06-30 16:00 +0200 |
| Message-ID | <tY4CL-6b8-29@gated-at.bofh.it> (permalink) |
| References | <tXPu2-4Pd-7@gated-at.bofh.it> <tXPu2-4Pd-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 29, 2017 at 11:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> The irq chip callbacks irq_request/release_resources() have absolutely no
> business with masking and unmasking the irq.
>
> The core code unmasks the interrupt after complete setup and masks it
> before invoking irq_release_resources().
>
> The unmask is actually harmful as it happens before the interrupt is
> completely initialized in __setup_irq().
>
> Remove it.
>
> Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-gpio@vger.kernel.org
Patch applied directly since it has no deps and fixes queued stuff for v4.13.
I guess Krysztof will make sure it doesn't break anything.
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Thomas Gleixner <tglx@linutronix.de> - 2017-06-29 23:50 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Tomasz Figa <tomasz.figa@gmail.com> - 2017-06-30 04:50 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-30 08:10 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Tomasz Figa <tomasz.figa@gmail.com> - 2017-06-30 08:30 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Thomas Gleixner <tglx@linutronix.de> - 2017-06-30 14:20 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Linus Walleij <linus.walleij@linaro.org> - 2017-06-30 14:20 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Linus Walleij <linus.walleij@linaro.org> - 2017-06-30 16:00 +0200
Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-30 17:00 +0200
csiph-web