Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677172
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] PM / wakeirq: Convert to SRCU |
| Date | 2017-06-28 23:10 +0200 |
| Message-ID | <tXsnM-2zA-9@gated-at.bofh.it> (permalink) |
| References | <tVQ1c-6d5-13@gated-at.bofh.it> <tWjFT-7Yc-7@gated-at.bofh.it> <tWIXD-72s-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday, June 26, 2017 01:37:11 PM Brian Norris wrote:
> On Sun, Jun 25, 2017 at 07:31:13PM +0200, Thomas Gleixner wrote:
> > The wakeirq infrastructure uses RCU to protect the list of wakeirqs. That
> > breaks the irq bus locking infrastructure, which is allows sleeping
> > functions to be called so interrupt controllers behind slow busses,
> > e.g. i2c, can be handled.
> >
> > The wakeirq functions hold rcu_read_lock and call into irq functions, which
> > in case of interrupts using the irq bus locking will trigger a
> > might_sleep() splat.
> >
> > Convert the wakeirq infrastructure to Sleepable RCU and unbreak it.
> >
> > Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ handling")
> > Reported-by: Brian Norris <briannorris@chromium.org>
> > Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > drivers/base/power/wakeup.c | 32 ++++++++++++++++++--------------
> > 1 file changed, 18 insertions(+), 14 deletions(-)
>
> This resolves the warnings I've seen, for sure. And I don't seem to have
> any new suspend/resume problems, so:
>
> Tested-by: Brian Norris <briannorris@chromium.org>
Applied with all tags, thanks!
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-24 12:00 +0200
Re: PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rafael@kernel.org> - 2017-06-24 14:10 +0200
Re: PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-24 14:20 +0200
Re: PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 14:40 +0200
Re: PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-24 16:00 +0200
Re: PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-25 11:20 +0200
Re: PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-25 16:50 +0200
[PATCH v2] PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-25 19:40 +0200
Re: [PATCH v2] PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-25 20:30 +0200
Re: [PATCH v2] PM / wakeirq: Convert to SRCU Tony Lindgren <tony@atomide.com> - 2017-06-26 12:20 +0200
Re: [PATCH v2] PM / wakeirq: Convert to SRCU Brian Norris <briannorris@chromium.org> - 2017-06-26 22:40 +0200
Re: [PATCH v2] PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-28 23:10 +0200
csiph-web