Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674075

Re: PM / wakeirq: Convert to SRCU

Show all headers | View raw

On Sat, 24 Jun 2017, Rafael J. Wysocki wrote:
> On Sat, Jun 24, 2017 at 11:56 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > The wakeirq infrastructure uses RCU to protect the list of wakeirqs. That
> > breaks the irq bus locking infrastructure, which allows sleeping functions
> > to be called so interrupt controllers behind slow busses, e.g. i2c, can be
> > handled.
> >
> > The wakeirq functions hold rcu_read_lock and call into irq functions, which
> > in case of interrupts using the irq bus locking will trigger a
> > might_sleep() splat.
> >
> > Convert the wakeirq infrastructure to Sleepable RCU and unbreak it.
> >
> > Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ handling")
> > Reported-by: Brian Norris <briannorris@chromium.org>
> > Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: stable@vger.kernel.org
> 
> OK
> 
> I guess it would be good to get this into 4.12?

I think so, but it probably wants some testing and breeding in next.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-24 12:00 +0200
  Re: PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rafael@kernel.org> - 2017-06-24 14:10 +0200
    Re: PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-24 14:20 +0200
      Re: PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 14:40 +0200
  Re: PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-24 16:00 +0200
    Re: PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-25 11:20 +0200
      Re: PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-25 16:50 +0200
        [PATCH v2]  PM / wakeirq: Convert to SRCU Thomas Gleixner <tglx@linutronix.de> - 2017-06-25 19:40 +0200
          Re: [PATCH v2]  PM / wakeirq: Convert to SRCU "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-25 20:30 +0200
            Re: [PATCH v2]  PM / wakeirq: Convert to SRCU Tony Lindgren <tony@atomide.com> - 2017-06-26 12:20 +0200
          Re: [PATCH v2]  PM / wakeirq: Convert to SRCU Brian Norris <briannorris@chromium.org> - 2017-06-26 22:40 +0200
            Re: [PATCH v2]  PM / wakeirq: Convert to SRCU "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-28 23:10 +0200

csiph-web