Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform
Date	2017-06-23 10:20 +0200
Message-ID	<tVrYR-8aL-7@gated-at.bofh.it> (permalink)
References	<tUfZL-1SN-3@gated-at.bofh.it> <tUfZM-1SN-11@gated-at.bofh.it> <tV5F0-26c-23@gated-at.bofh.it> <tVhPQ-1Gi-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 22, 2017 at 09:20:59PM +0000, Chris Packham wrote:
> On 22/06/17 20:23, Wolfram Sang wrote:
> > 
> >> + - reset-gpios : gpio specifier for gpio connected to RESET_N pin.
> > 
> > What about the 'active' state that Rob mentioned in his last review?
> > 
> 
> My intention was that by saying it is connected to the RESET_N bin the 
> active state is covered.
> 
> I personally always get a little confused when talking about reset 
> lines. The _N denotes that the line is active low but because it is a 
> reset line writing 1 releases the reset so from a what-the-user-wants 
> perspective it's active high.
> 
> dt-binding-wise what we want here is GPIO_ACTIVE_HIGH, as in the driver 
> writes 1 to release reset so don't do any polarity inversion. I'd be 
> happy do add something to that effect in a v3 but I actually felt saying 
> the gpio is connected to RESET_N was less ambiguous.

Okay. Thanks for the explanation. I am fine with it but I'll leave the
final decision to Rob.

Thread

[PATCH v2 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
  [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
    Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-22 10:30 +0200
      Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-22 23:30 +0200
        Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 10:20 +0200
        Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh@kernel.org> - 2017-06-23 23:50 +0200
  [PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
  [PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
  [PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:30 +0200
  [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
    Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
    Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
      Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:50 +0200
      Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:20 +0200
  [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
    Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh+dt@kernel.org> - 2017-06-26 16:10 +0200
    Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
  [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
    Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
    Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
      Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:30 +0200
        Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-29 00:20 +0200
  [PATCH v3 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
    [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
      Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
        Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
          Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
            Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:10 +0200
    [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
      Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
        Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
          Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
            Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 14:10 +0200

csiph-web