Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677039

Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls.

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote:
> On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic

> > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] = {
> > +       SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL,
> > +                       SUN4I_CODEC_DAC_ACTL_LDACLMIXS,
> >                         SUN4I_CODEC_DAC_ACTL_RDACRMIXS, 1, 0),

> This changes the mixer control names exposed to userspace. While I think
> consolidating mixer controls is nice, giving the user a less cluttered
> view, I'm not sure about the changing a possible userspace ABI.

> Maxime, ALSA and ASoC people, any comments about this?

It's better not to change things but on the other hand it really depends
if there's any users who will notice - if nobody notices it doesn't
matter.

Can we *please* get some review of the rest of this series?  It's
enormous, we're on version *13* and the first review on this version
here is on patch 5.  If the first four patches are fine then please says
so, if they're not then let's have some review comments so things can
move towards merging them.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v13 00/14] ASoC: sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic <dannym@scratchpost.org> - 2017-06-24 08:30 +0200
  [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. Danny Milosavljevic <dannym@scratchpost.org> - 2017-06-24 08:30 +0200
    Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls  and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. Chen-Yu Tsai <wens@csie.org> - 2017-06-26 03:50 +0200
      Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge  sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into  sun4i_codec_mixer_controls. Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-26 21:30 +0200
        Re: [linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge  sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into  sun4i_codec_mixer_controls. Danny Milosavljevic <dannym@scratchpost.org> - 2017-06-28 10:30 +0200
          Re: [linux-sunxi] Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge  sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. Chen-Yu Tsai <wens@csie.org> - 2017-06-28 10:40 +0200
      Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge  sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into  sun4i_codec_mixer_controls. Mark Brown <broonie@kernel.org> - 2017-06-28 20:20 +0200
  [PATCH v13 08/14] ASoC: sun4i-codec: Add FM Left, FM Right, FM Playback Switch. Danny Milosavljevic <dannym@scratchpost.org> - 2017-06-24 08:30 +0200
  Re: [PATCH v13 00/14] ASoC: sun4i-codec: Add Line-In, FM-In, Mic 2,  Capture Source, Differential Line-In Chen-Yu Tsai <wens@csie.org> - 2017-06-28 11:20 +0200

csiph-web