Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677040

Re: [PATCH 14/20] dt-bindings: serial: document option wake-up interrupt for STM32 USART

Show all headers | View raw

On Mon, Jun 26, 2017 at 12:49:15PM +0000, Bich HEMON wrote:
> From: Bich Hemon <bich.hemon@st.com>
> 
> Introduce new compatibles for "st,stm32h7-usart" and "st,stm32h7-uart".
> This new compatible allow to use optional wake-up interrupt.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
>  .../devicetree/bindings/serial/st,stm32-usart.txt    | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> index a229b14..3b42138 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> @@ -2,11 +2,14 @@
>  
>  Required properties:
>  - compatible: Can be either "st,stm32-usart", "st,stm32-uart",
> -"st,stm32f7-usart" or "st,stm32f7-uart" depending on whether
> -the device supports synchronous mode and is compatible with
> -stm32(f4) or stm32f7.
> +"st,stm32f7-usart", "st,stm32f7-uart", "st,stm32h7-usart" or
> +st,stm32h7-uart depending on whether the device supports synchronous
> +mode and is compatible with stm32(f4), stm32f7 or stm32h7.

Please reformat as 1 valid set of compatibles per line.

>  - reg: The address and length of the peripheral registers space
> -- interrupts: The interrupt line of the USART instance
> +- interrupts or interrupts-extended: Must contain first, the interrupt
> +  line specifier for the USART instance. An optional wake-up interrupt
> +  specifier can be added. Then, -extended variant may be needed to specify
> +  interrupts parent controllers.

Just describe the interrupts property and what the interrupts are. 
interrupts-extended is implied if it is necessary.

>  - clocks: The input clock of the USART instance
>  
>  Optional properties:
> @@ -53,3 +56,12 @@ usart1: serial@40011000 {
>  	       <&dma2 7 4 0x414 0x0>;
>  	dma-names = "rx", "tx";
>  };
> +
> +uart4: serial@40010000 {
> +	compatible = "st,stm32h7-uart";
> +	reg = <0x40010000 0x400>;
> +	interrupts-extended = <&intc GIC_SPI 52 IRQ_TYPE_NONE>,
> +			      <&aiec 30 1>;
> +	clocks = <&rcc UART4_K>;
> +	status = "disabled";
> +};
> -- 
> 1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/20] Update STM32 usart driver Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  [PATCH 19/20] serial: stm32: add dma rx callback Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  [PATCH 06/20] serial: stm32: fix pio transmit timeout Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  [PATCH 14/20] dt-bindings: serial: document option wake-up interrupt  for STM32 USART Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
    Re: [PATCH 14/20] dt-bindings: serial: document option wake-up  interrupt for STM32 USART Rob Herring <robh@kernel.org> - 2017-06-28 20:20 +0200
    Re: [PATCH 14/20] dt-bindings: serial: document option wake-up  interrupt for STM32 USART Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 17:00 +0200
  [PATCH 12/20] serial: stm32: fix last_res value Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  [PATCH 13/20] serial: stm32: fix error handling in probe Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
    Re: [PATCH 13/20] serial: stm32: fix error handling in probe Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 17:00 +0200
  [PATCH 04/20] serial: stm32: make fifoen as property for each port Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  [PATCH 08/20] serial: stm32: timeout interrupt using with dma Bich HEMON <bich.hemon@st.com> - 2017-06-26 15:00 +0200
  Re: [PATCH 00/20] Update STM32 usart driver Alexandre Torgue <alexandre.torgue@st.com> - 2017-06-29 17:20 +0200

csiph-web