Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
Date	2017-06-28 20:20 +0200
Message-ID	<tXpJh-Rv-17@gated-at.bofh.it> (permalink)
References	<tXlmh-7nt-3@gated-at.bofh.it> <tXppY-t5-87@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 28/06/17 18:21, Ritesh Harjani wrote:
> Hi Srinivas,
> 
> On 6/28/2017 7:05 PM, srinivas.kandagatla@linaro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> This patchset adds quirk to support cards which have issues when sdma
>> boundary buffer bits are programmed in Block Size Register (0x04)
>> when using ADMA.
> 
> Thanks for pointing out the reason of failure without this patch.
> Earlier I could not find the reason.
> 
> Previous discussion link :-
> https://patchwork.kernel.org/patch/9200579/

I did see this patch, only issue I had is making it default.

> 
> 
>>
>> First patch adds quirk and second one uses that quirk in msm sdhci 
>> driver.
> 
> Not sure if quirk will be the right way to go about this, or whether we 
> should make this functionality default since ADMA does not
> uses this (as per spec) ?
> Since other systems should not break (as Adrian was mentioning in the 
> discussion link above).
> 
That was the only reason to add this as quirk, so that other drivers 
would work as it previously.

Also, this seems to be a issue with only qcom controller, so quirk makes 
more sense for me.

> Adrian/Ulf will know better on this.
> 

--srini
>>
>> Tested on DB410c with WLAN SDIO card.
>>
>> thanks,
>> srini
>>
>> Srinivas Kandagatla (2):
>>    mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
>>    mmc: sdhci-msm: enable SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER
>>
>>   drivers/mmc/host/sdhci-msm.c |  3 ++-
>>   drivers/mmc/host/sdhci.c     | 24 ++++++++++++++++++------
>>   drivers/mmc/host/sdhci.h     |  2 ++
>>   3 files changed, 22 insertions(+), 7 deletions(-)
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER srinivas.kandagatla@linaro.org - 2017-06-28 15:40 +0200
  Re: [RFC PATCH 0/2] mmc: sdhci: Add  SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Ritesh Harjani <riteshh@codeaurora.org> - 2017-06-28 20:00 +0200
    Re: [RFC PATCH 0/2] mmc: sdhci: Add  SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-06-28 20:20 +0200

csiph-web