Path: csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Srinivas Kandagatla Newsgroups: linux.kernel Subject: Re: [RFC PATCH 0/2] mmc: sdhci: Add SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER Date: Wed, 28 Jun 2017 20:20:03 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=29fpdInCVFFs7JhRbX2Sih7fkP3CuknqO+p6AfqteqA=; b=VXGuCKBAvuDMeJMvtbU0/n8EwcBdWINbqg8jk4FBEo9Szq1qr7AsuiHh5LgccEdgve WDnZIzegvSYuQXaEKyDnR5zMbuC8NOqnxC987A68tD1sSvwe9N/whjvEr9WfXd5VFbvE Z/YmZk6jM/LoesNTeUX3DCjBjt7GeJIa9P0Y0= X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=29fpdInCVFFs7JhRbX2Sih7fkP3CuknqO+p6AfqteqA=; b=Mto8CzGR0b4Zakso1epWjbrGxuFlBgYA9IhkcRD/WbAWtNfN+ubBxRPRJXRU+AIr3Q 2hcH1X/JVCCyfL4T4FXikHnVXvXK00cOeulH5KWB0ZgOxJkJKUdhOCH4WOfIPGqSUfOl KONJJx9aJPMfAVXlwJDHqNjYeusb06wViF11yxeLdb2BHWXC3ahOHxzkeVRjN1zJ87cs tIaIrssMslowxX97pN6stQH9VdKcVQGn2BV9MI79zsKV6yCV6qgg7WfJmqzXqwc7x6j9 XE5LUn3O1tb81XoiK2aPjjUFB+KlHgfsU5EWMiCHK7Kgi6+t95WUuHy7ITU5EJFaG5xd HsHw== X-Gm-Message-State: AKS2vOyrofLfxFbyUIWynhe/WUnB5kbKDt7Ei38zGrFlym4h7fJ9MtrX WV0Zs+iZvoZA6/bf X-Received: by 10.223.171.3 with SMTP id q3mr19695397wrc.12.1498673778407; Wed, 28 Jun 2017 11:16:18 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 58 Organization: linux.* mail to news gateway X-Original-Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org X-Original-Date: Wed, 28 Jun 2017 19:16:16 +0100 X-Original-Message-ID: <799ab3c1-ef36-0137-0064-63823c1598d3@linaro.org> X-Original-References: <20170628133504.17422-1-srinivas.kandagatla@linaro.org> <552ef0ba-91d5-ab9c-d55c-ac008608a689@codeaurora.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1677034 On 28/06/17 18:21, Ritesh Harjani wrote: > Hi Srinivas, > > On 6/28/2017 7:05 PM, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> This patchset adds quirk to support cards which have issues when sdma >> boundary buffer bits are programmed in Block Size Register (0x04) >> when using ADMA. > > Thanks for pointing out the reason of failure without this patch. > Earlier I could not find the reason. > > Previous discussion link :- > https://patchwork.kernel.org/patch/9200579/ I did see this patch, only issue I had is making it default. > > >> >> First patch adds quirk and second one uses that quirk in msm sdhci >> driver. > > Not sure if quirk will be the right way to go about this, or whether we > should make this functionality default since ADMA does not > uses this (as per spec) ? > Since other systems should not break (as Adrian was mentioning in the > discussion link above). > That was the only reason to add this as quirk, so that other drivers would work as it previously. Also, this seems to be a issue with only qcom controller, so quirk makes more sense for me. > Adrian/Ulf will know better on this. > --srini >> >> Tested on DB410c with WLAN SDIO card. >> >> thanks, >> srini >> >> Srinivas Kandagatla (2): >> mmc: sdhci: add quirk SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER >> mmc: sdhci-msm: enable SDHCI_QUIRK2_BROKEN_SDMA_BOUNDARY_BUFFER >> >> drivers/mmc/host/sdhci-msm.c | 3 ++- >> drivers/mmc/host/sdhci.c | 24 ++++++++++++++++++------ >> drivers/mmc/host/sdhci.h | 2 ++ >> 3 files changed, 22 insertions(+), 7 deletions(-) >> >