Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678060

Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel

Show key headers only | View raw

Hi Sebastian,

On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
> @@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev)
>  	if (!da9052)
>  		return -EINVAL;
>  
> +	/*
> +	 * Check if touchscreen pins are used are analogue input instead
> +	 * of having a touchscreen connected to them. The analogue input
> +	 * functionality will be provided by hwmon driver (if enabled).
> +	 */
> +	if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc"))
> +		return -ENODEV;
> +

I believe this is not the right way of doing this. da9052-core should
simply forgo creating da9052-tsi platform device when this property is
present.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv3 0/4] DA9052 hardware monitoring improvements Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-29 14:50 +0200
  [PATCHv3 2/4] hwmon: da9052: replace S_IRUGO with 0444 Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-29 14:50 +0200
  [PATCHv3 3/4] dt-bindings: mfd: da9052: support TSI as ADC Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-29 14:50 +0200
  [PATCHv3 1/4] mfd: da9052: fix manual ADC read after timed out read Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-29 14:50 +0200
  [PATCHv3 4/4] hwmon: da9052: add support for TSI channel Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-29 14:50 +0200
    Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-29 20:50 +0200
      Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel Guenter Roeck <linux@roeck-us.net> - 2017-06-30 00:50 +0200

csiph-web