Re: [PATCH 12/16] switchtec_ntb: add link management

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/16] switchtec_ntb: add link management
Date	2017-06-29 20:40 +0200
Message-ID	<tXMwb-2FO-37@gated-at.bofh.it> (permalink)
References	<tXyjw-2hu-3@gated-at.bofh.it> <tXytb-2ks-9@gated-at.bofh.it> <tXMcN-2zD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6/29/2017 12:11 PM, Allen Hubbe wrote:

> Should we only set self_partition?  I think each peer should be able to set preferred speed, and negotiate down.  As written here, the last peer to set the speed overrides the setting on the peer, and even that is not atomic if they race.

This function isn't actually setting the link speed. (Though I can 
understand the confusion from the name.) It's just reporting the slowest 
speed on the link between the peers for the link_is_up function. (Each 
port will have negotiated it's own speed).

I don't think switchtec has the ability to actually change the port 
speed or width. (Seeing they are negotiated on boot).

Logan

Thread

[PATCH 00/16] Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:30 +0200
  [PATCH 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:30 +0200
    RE: [PATCH 14/16] switchtec_ntb: implement scratchpad registers "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 20:20 +0200
      Re: [PATCH 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 20:40 +0200
  [PATCH 09/16] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:30 +0200
  [PATCH 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:30 +0200
  [PATCH 04/16] switchtec: add link event notifier callback Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:40 +0200
  [PATCH 05/16] ntb: ensure ntb_mw_get_align is only called when the link is up Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:40 +0200
    RE: [PATCH 05/16] ntb: ensure ntb_mw_get_align is only called when the link is up "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 20:20 +0200
  [PATCH 12/16] switchtec_ntb: add link management Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:40 +0200
    RE: [PATCH 12/16] switchtec_ntb: add link management "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 20:20 +0200
      Re: [PATCH 12/16] switchtec_ntb: add link management Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 20:40 +0200
  [PATCH 11/16] switchtec_ntb: add skeleton ntb driver Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:40 +0200
  [PATCH 10/16] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:40 +0200
  Re: [PATCH 00/16] Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 17:20 +0200
    Re: [PATCH 00/16] Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 17:40 +0200

csiph-web