Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation
Date	Thu, 29 Jun 2017 16:30:04 +0200
Message-ID	<tXICf-eR-43@gated-at.bofh.it> (permalink)
References	<tWTq2-5LM-13@gated-at.bofh.it>
X-Original-To	Jaya Durga <rjdurga@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.3 (2017-05-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	devel@driverdev.osuosl.org, binoy.jayan@linaro.org, Jaya Durga <jayad@cdac.in>, arnd@arndb.de, florian.c.schilhabel@googlemail.com, rvarsha016@gmail.com, louie.lu@hopebaytech.com, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, Larry.Finger@lwfinger.net
X-Original-Date	Thu, 29 Jun 2017 16:20:04 +0200
X-Original-Message-ID	<20170629142004.GA29769@kroah.com>
X-Original-References	<1498548961-8776-1-git-send-email-rjdurga@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1677816

Show key headers only | View raw

On Tue, Jun 27, 2017 at 01:06:00PM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> 
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I have a bizarre series of oddly numbered patches from you, and no where
is a whole, correctly numbered, set of patches that I can sort correctly
and apply to my tree knowing that I did not miss any.

So I've now dropped all of your patches you have sent to me from my
queue.  Please redo them all and resend them properly numbered in a
manner that makes it _obvious_ what ones I should review and what order
they should be applied in.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga <rjdurga@gmail.com> - 2017-06-27 09:50 +0200
  Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal  permission representation Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 16:30 +0200

csiph-web