Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677746

Re: [PATCH] gpiolib: fix filtering out unwanted events

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] gpiolib: fix filtering out unwanted events
Date 2017-06-29 15:20 +0200
Message-ID <tXHwu-84k-9@gated-at.bofh.it> (permalink)
References <tVvg6-1Cs-9@gated-at.bofh.it> <tVvg6-1Cs-7@gated-at.bofh.it> <tXE5A-5Ru-17@gated-at.bofh.it> <tXFuF-6OW-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> 2017-06-29 11:33 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
>> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>>
>>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>>> evaluated to true even if only one event type was requested.
>>>
>>> Fix it by checking both RISING & FALLING flags explicitly.
>>>
>>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>>
>> Patch applied for fixes.
>>
>> Yours,
>> Linus Walleij
>
> Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
> affected). Will you forward it or should I do it myself?

I have added the stable tag so it should JustWork(TM).

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 13:50 +0200
  [PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 13:50 +0200
    Re: [PATCH] gpiolib: fix filtering out unwanted events Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 11:40 +0200
      Re: [PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-29 13:10 +0200
        Re: [PATCH] gpiolib: fix filtering out unwanted events Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 15:20 +0200
  Re: [PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 16:10 +0200

csiph-web