Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673492
| From | Bartosz Golaszewski <brgl@bgdev.pl> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] gpiolib: fix filtering out unwanted events |
| Date | 2017-06-23 13:50 +0200 |
| Message-ID | <tVvg6-1Cs-7@gated-at.bofh.it> (permalink) |
| References | <tVvg6-1Cs-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
evaluated to true even if only one event type was requested.
Fix it by checking both RISING & FALLING flags explicitly.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
drivers/gpio/gpiolib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5db4413..a42a1ee 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -708,7 +708,8 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p)
ge.timestamp = ktime_get_real_ns();
- if (le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES) {
+ if (le->eflags & GPIOEVENT_REQUEST_RISING_EDGE
+ && le->eflags & GPIOEVENT_REQUEST_FALLING_EDGE) {
int level = gpiod_get_value_cansleep(le->desc);
if (level)
--
2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 13:50 +0200
[PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 13:50 +0200
Re: [PATCH] gpiolib: fix filtering out unwanted events Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 11:40 +0200
Re: [PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-29 13:10 +0200
Re: [PATCH] gpiolib: fix filtering out unwanted events Linus Walleij <linus.walleij@linaro.org> - 2017-06-29 15:20 +0200
Re: [PATCH] gpiolib: fix filtering out unwanted events Bartosz Golaszewski <brgl@bgdev.pl> - 2017-06-23 16:10 +0200
csiph-web