Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677652
| From | Wanpeng Li <kernellwp@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay |
| Date | 2017-06-29 14:00 +0200 |
| Message-ID | <tXGh3-774-5@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <tXyCR-2nE-3@gated-at.bofh.it> <tXCwP-4ON-29@gated-at.bofh.it> <tXCQa-5a5-9@gated-at.bofh.it> <tXDjb-5jp-11@gated-at.bofh.it> <tXG7o-71O-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2017-06-29 19:43 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 29/06/2017 10:44, Wanpeng Li wrote:
>>>> You still need to enable the preemption timer even if you return 1, so
>>>> in lapic.c it becomes
>>>>
>>>> if (!apic_lvtt_period(apic)) {
>>>> if (r)
>>>> apic_timer_expired(apic);
>>>> if (atomic_read(&apic->lapic_timer.pending))
>>>> need_cancel = true;
>>>> }
>>> I think the codes are more clear but the same as above. We didn't
>>> program preemption timer vmcs field if delta == 0, so how to
>>> understand "need to enable the preemption timer even if return 1"?
>> I guess you mean start_hv_timer() should return true, right?
>
> vmx.c's set_hv_timer callback should set the preemption timer execution
> control. Otherwise, kvm_lapic_hv_timer_expired is again not called.
I see, this should be set for apic timer periodic mode.
Regards,
Wanpeng Li
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 03:30 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 14:20 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:00 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 16:10 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:10 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:30 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 16:40 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 05:50 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 10:00 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 10:20 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 10:50 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 13:50 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 14:00 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 14:10 +0200
Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 14:20 +0200
csiph-web