Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677669

Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay
Date 2017-06-29 14:20 +0200
Message-ID <tXGAp-7t8-3@gated-at.bofh.it> (permalink)
References (2 earlier) <tXm8F-7TU-1@gated-at.bofh.it> <tXmim-7Xs-19@gated-at.bofh.it> <tXyCR-2nE-3@gated-at.bofh.it> <tXCwP-4ON-29@gated-at.bofh.it> <tXGqL-7pH-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 29/06/2017 14:05, Wanpeng Li wrote:
> +            /* In case the sw timer triggered in the window */
> +            if (!apic_lvtt_period(apic)) {
> +                if (r || atomic_read(&apic->lapic_timer.pending)) {
> +                    need_cancel = true;
> +                    if (r)
> +                    apic_timer_expired(apic);
> +                }
> +            }

Yes, that's equivalent.  The compiler should thread the jumps as if it were:

	if (r) {
		apic_timer_expired(apic);
		goto cancel_timer;
	}
	if (atomic_read(&apic->lapic_timer.pending))
		goto cancel_timer;

so it produces pretty good code too.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 03:30 +0200
  Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 14:20 +0200
    Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:00 +0200
      Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 16:10 +0200
        Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:10 +0200
    Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-28 16:30 +0200
      Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-28 16:40 +0200
        Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 05:50 +0200
          Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 10:00 +0200
            Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 10:20 +0200
              Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 10:50 +0200
                Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 13:50 +0200
                Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 14:00 +0200
            Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Wanpeng Li <kernellwp@gmail.com> - 2017-06-29 14:10 +0200
              Re: [PATCH v3] KVM: LAPIC: Fix lapic timer injection delay Paolo Bonzini <pbonzini@redhat.com> - 2017-06-29 14:20 +0200

csiph-web