Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676271

Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs

From Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs
Date 2017-06-28 01:50 +0200
Message-ID <tX8p4-7z8-21@gated-at.bofh.it> (permalink)
References <tX7sZ-6Yu-11@gated-at.bofh.it> <tX7t0-6Yu-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue 27 Jun 15:46 PDT 2017, Suman Anna wrote:

> Drop the dependency on RESET_CONTROLLER for the Keystone remoteproc
> driver to resolve some circular dependencies around different choices
> for RESET_CONTROLLER on common ARM configs. This dependency is
> inherent as the RESET_CONTROLLER will be enabled due to the enabled
> ARCH_HAS_RESET_CONTROLLER for ARCH_KEYSTONE.
> 

As my approach requires synchronized changes to rproc-next and
rpmsg-next and we're close to the merge window I'll pick this
"workaround" for now, thanks!

I do think it's appropriate for the Keystone remoteproc driver to
express its dependency on reset-controller, so I intend to revert this
as I look into this issue after -rc1 again.


Merged all 4 patches.

Regards,
Bjorn

> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  drivers/remoteproc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 945c1574f896..8891a8e50f12 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -70,7 +70,6 @@ config DA8XX_REMOTEPROC
>  config KEYSTONE_REMOTEPROC
>  	tristate "Keystone Remoteproc support"
>  	depends on ARCH_KEYSTONE
> -	depends on RESET_CONTROLLER
>  	select RPMSG_VIRTIO
>  	help
>  	  Say Y here here to support Keystone remote processors (DSP)
> -- 
> 2.13.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Some remoteproc/rpmsg Kconfig cleanups Suman Anna <s-anna@ti.com> - 2017-06-28 00:50 +0200
  [PATCH 3/4] remoteproc: Drop redundant REMOTEPROC dependency from driver Kconfigs Suman Anna <s-anna@ti.com> - 2017-06-28 00:50 +0200
  [PATCH 1/4] rpmsg: Drop VIRTUALIZATION dependency from RPMSG_VIRTIO Suman Anna <s-anna@ti.com> - 2017-06-28 00:50 +0200
  [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs Suman Anna <s-anna@ti.com> - 2017-06-28 00:50 +0200
    Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for  ARM configs Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-06-28 01:50 +0200
      Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for  ARM configs Suman Anna <s-anna@ti.com> - 2017-06-28 20:00 +0200

csiph-web