Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676270

Re: [PATCH v2 0/5] PM: Unify the handling of device wakeup settings

Show all headers | View raw

Hi Rafael,

On Sat, Jun 24, 2017 at 01:50:55AM +0200, Rafael J. Wysocki wrote:
> On Monday, June 19, 2017 11:31:58 PM Rafael J. Wysocki wrote:
> > Hi All,
> > 
> > The handling of device wakeup settings, especially in the ACPI core and the PCI
> > bus type, depends on whether it is about system wakeup from sleep states or
> > remote wakeup in the working state (runtime).  However, that distinction is
> > mostly based on the ACPI concept of "wakeup" and "runtime" GPEs, which is
> > somewhat artificial, because the underlying hardware mechanism is basically
> > the same in both cases.
> > 
> > Moreover, suspend-to-idle is now supported as a sleep state and wakeup from it
> > is based on exactly the same hardware capabilities as the working-state
> > (runtime) remote wakeup.
> > 
> > The following patch series removes that distinction and unifies the handling of
> > device wakeup settings between system sleep and runtime.  It also fixes one
> > issue related to wakeup signaling through PCI bridges.
> > 
> > [1/6]: Get rid of the "runtime wakeup" concept from the ACPI core.
> > [2/6]: Unify device wakeup settings code paths in the ACPI core.
> > [3-4/6]: Unify device wakeup settings code paths in the PCI bus type code.
> > [5/6]: Fix wakeup-related issue with bridges in the PCI bus type code.
> > [6/6]: Get rid of the "runtime wakeup" concept from the driver core.
> > 
> > The series is based on current linux-next and will be made available for
> > testing in the linux-pm.git tree in a couple of days.
> 
> Here's a v2 with tentatively added Reviewed-by tags from Mika.
> 
> I've dropped patch [5/6] from the previous iteration as it didn't really belong
> here and the issue it attempted to fix is rather theoretical.  I'm going to
> take a different approach there.
> 
> Apart from this, the function previously called acpi_pm_device_wakeup() has
> a different name now: acpi_pm_set_device_wakeup(), to possibly avoid
> confusion about its purpose.
> 
> Also the changelog of patch [3/5] has been modified slightly.

This series does touch drivers/pci, but is mostly ACPI.  Do you want
to take it via your tree?  I have a couple PM changes in my tree, but
I don't see anything that should conflict with this series.

For the PCI parts:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] PM: Unify the handling of device wakeup settings "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  [PATCH v2 4/5] PCI / PM: Simplify device wakeup settings code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  [PATCH v2 5/5] PM / core: Drop run_wake flag from struct dev_pm_info "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  [PATCH v2 2/5] ACPI / PM: Consolidate device wakeup settings code "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  [PATCH v2 1/5] ACPI / PM: Drop run_wake from struct acpi_device_wakeup_flags "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  [PATCH v2 3/5] PCI / PM: Drop pme_interrupt flag from struct pci_dev "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-24 02:10 +0200
  Re: [PATCH v2 0/5] PM: Unify the handling of device wakeup settings "Rafael J. Wysocki" <rafael@kernel.org> - 2017-06-28 01:50 +0200
  Re: [PATCH v2 0/5] PM: Unify the handling of device wakeup settings Bjorn Helgaas <helgaas@kernel.org> - 2017-06-28 01:50 +0200

csiph-web