Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

From	Brendan Higgins <brendanhiggins@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C
Date	2017-06-28 01:50 +0200
Message-ID	<tX8p4-7z8-19@gated-at.bofh.it> (permalink)
References	<tUyJ4-5qy-1@gated-at.bofh.it> <tUyJ4-5qy-3@gated-at.bofh.it> <tVBOy-5Jh-19@gated-at.bofh.it> <tWUcq-6mA-23@gated-at.bofh.it> <tWUFs-6Nx-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 27, 2017 at 2:00 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> > If SCL is stuck low, how do you want to send a STOP?
>> >
>>
>> Fair point. I should probably drop that in the future and just do a
>> reset, and even then, doing a
>> reset is probably just wishful thinking. If a slave is holding down
>> SCL, we are pretty screwed.
>
> Yes, you'd need to reset the client device. And that has to be done in
> the client driver. I wonder if i2c_transfer and friends should return a
> specific error value in that case... need to think about it.
>

Well, a good first step would be to make my recovery code conform to
the struct i2c_bus_recovery_info. Is i2c_generic_scl_recovery supposed
to be part of the user interface, or is it just intended to help put the
main recovery function together?

Thread

[PATCH v11 0/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
  [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
    Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
      Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Joel Stanley <joel@jms.id.au> - 2017-06-26 08:20 +0200
        Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-27 10:40 +0200
      Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-27 10:40 +0200
        Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 11:10 +0200
          Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-28 01:50 +0200
            Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 09:50 +0200
  [PATCH v11 2/4] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
    Re: [PATCH v11 2/4] i2c: aspeed: added documentation for Aspeed I2C  driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
  [PATCH v11 4/4] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
    Re: [PATCH v11 4/4] i2c: aspeed: added slave support for Aspeed I2C  driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
  [PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
    Re: [PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200

csiph-web