Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675414
| From | Brendan Higgins <brendanhiggins@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C |
| Date | 2017-06-27 10:40 +0200 |
| Message-ID | <tWUcq-6mA-23@gated-at.bofh.it> (permalink) |
| References | <tUyJ4-5qy-1@gated-at.bofh.it> <tUyJ4-5qy-3@gated-at.bofh.it> <tVBOy-5Jh-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 23, 2017 at 11:43 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Tue, Jun 20, 2017 at 02:15:15PM -0700, Brendan Higgins wrote:
>> Added initial master support for Aspeed I2C controller. Supports
>> fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Applied to for-next, thanks for all the hard work!
Thanks for the patience!
>
> One question however which can be solved incrementally if needed:
>
>> + if (command & ASPEED_I2CD_SDA_LINE_STS) {
>> + /* Bus is idle: no recovery needed. */
>> + if (command & ASPEED_I2CD_SCL_LINE_STS)
>> + goto out;
>> + dev_dbg(bus->dev, "SCL hung (state %x), attempting recovery\n",
>> + command);
>> +
>> + reinit_completion(&bus->cmd_complete);
>> + writel(ASPEED_I2CD_M_STOP_CMD, bus->base + ASPEED_I2C_CMD_REG);
>
> If SCL is stuck low, how do you want to send a STOP?
>
Fair point. I should probably drop that in the future and just do a
reset, and even then, doing a
reset is probably just wishful thinking. If a slave is holding down
SCL, we are pretty screwed.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v11 0/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
[PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Joel Stanley <joel@jms.id.au> - 2017-06-26 08:20 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-27 10:40 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-27 10:40 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 11:10 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-06-28 01:50 +0200
Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 09:50 +0200
[PATCH v11 2/4] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
Re: [PATCH v11 2/4] i2c: aspeed: added documentation for Aspeed I2C driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
[PATCH v11 4/4] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
Re: [PATCH v11 4/4] i2c: aspeed: added slave support for Aspeed I2C driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
[PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-06-20 23:20 +0200
Re: [PATCH v11 1/4] MAINTAINERS: add entry for Aspeed I2C driver Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 20:50 +0200
csiph-web