Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1676201

Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot

From Ralf Baechle <ralf@linux-mips.org>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot
Date 2017-06-27 23:50 +0200
Message-ID <tX6wW-6nD-43@gated-at.bofh.it> (permalink)
References <tX4lt-4ZQ-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 27, 2017 at 07:22:16PM +0000, Karl Beldan wrote:

> In this sequence the 'move' is assumed in the delay slot of the 'beq',
> but head.S is in reorder mode and the former gets pushed one 'nop'
> farther by the assembler.
> 
> The corrected behavior made booting with an UHI supplied dtb erratic.

Excellent catch, patch applied!

Thanks Karl,

  Ralf

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot Karl Beldan <karl.beldan@gmail.com> - 2017-06-27 21:30 +0200
  Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay  slot James Hogan <james.hogan@imgtec.com> - 2017-06-27 22:40 +0200
  Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay  slot Ralf Baechle <ralf@linux-mips.org> - 2017-06-27 23:50 +0200

csiph-web