Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674405

Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls

Show all headers | View raw

On Sat, Jun 24, 2017 at 11:45:01AM -0700, Deepa Dinamani wrote:
> The series aims at isolating data conversions of time_t based structures:
> struct timespec and struct itimerspec at user space boundaries.
> This helps to later change the underlying types to handle y2038 changes
> to these.

Nice...  A few questions:

* what about setitimer(2)?  Right now that's the only remaining user of
get_compat_itimerval(); similar for getitimer(2) and put_compat_itimerval().

* you have two callers of get_compat_itimerspec64(); one is followed by
itimerspec64_valid(), another - by its open-coded analogue.  The same
goes for get_itimerspec64(); wouldn't it be better to have both check
the validity immediately and simply fail with -EINVAL?  Matter of taste,
but...

* should __sys_recvmmsg() switch to timespec64?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 5/7] nanosleep: Use get_timepsec64() and put_timespec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 7/7] posix_clocks: Use get_itimerspec64() and  put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 3/7] posix-stubs: Conditionally include COMPAT_SYS_NI defines Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 6/7] timerfd: Use get_itimerspec64() and put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-26 04:40 +0200
    Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-26 06:20 +0200
    Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-26 20:20 +0200
      Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Arnd Bergmann <arnd@arndb.de> - 2017-06-26 22:10 +0200
        Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-27 07:00 +0200
        Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer  syscalls Thomas Gleixner <tglx@linutronix.de> - 2017-07-03 12:30 +0200
          Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Arnd Bergmann <arnd@arndb.de> - 2017-07-03 13:30 +0200

csiph-web