Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675286

Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls

Show all headers | View raw

>>>> The series aims at isolating data conversions of time_t based structures:
>>>> struct timespec and struct itimerspec at user space boundaries.
>>>> This helps to later change the underlying types to handle y2038 changes
>>>> to these.
>>>
>>> Nice...  A few questions:
>>>
>>> * what about setitimer(2)?  Right now that's the only remaining user of
>>> get_compat_itimerval(); similar for getitimer(2) and put_compat_itimerval().
>>
>> We do not plan to support these beyond y2038 on 32 bit systems.
>> timer_settime() and timer_gettime() are considered to be replacements
>> for these, respectively.
>>
>> There is also going to be a cleanup of timeval/ timespec/ time_t data
>> types and apis after the new syscalls are ready.
>> At that time I might choose to get rid of these itimerval apis. I'm
>> not sure yet.
>
> I see that internally, alarm/getitimer/setitimer all use ktime_t, so
> one possible solution would be to push down the use of ktime_t
> into the callers and do both the conversion and range check in the
> user copy function.

Right. This is one way of doing it. I was asking if you guys are okay
with doing this as a cleanup series later or would you like for it to
be part of the current series?

-Deepa

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 5/7] nanosleep: Use get_timepsec64() and put_timespec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 7/7] posix_clocks: Use get_itimerspec64() and  put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 3/7] posix-stubs: Conditionally include COMPAT_SYS_NI defines Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  [PATCH v3 6/7] timerfd: Use get_itimerspec64() and put_itimerspec64() Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-24 21:00 +0200
  Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-26 04:40 +0200
    Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Al Viro <viro@ZenIV.linux.org.uk> - 2017-06-26 06:20 +0200
    Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-26 20:20 +0200
      Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Arnd Bergmann <arnd@arndb.de> - 2017-06-26 22:10 +0200
        Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Deepa Dinamani <deepa.kernel@gmail.com> - 2017-06-27 07:00 +0200
        Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer  syscalls Thomas Gleixner <tglx@linutronix.de> - 2017-07-03 12:30 +0200
          Re: [PATCH v3 0/7] Isolate time_t data types for clock/timer syscalls Arnd Bergmann <arnd@arndb.de> - 2017-07-03 13:30 +0200

csiph-web