Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674936

Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property

Show all headers | View raw

On Mon, Jun 26, 2017 at 11:00:11AM -0500, Rob Herring wrote:
> On Wed, Jun 21, 2017 at 06:01:49PM +0800, Jeffy Chen wrote:
> > Update document devicetree bindings to support "wakeup-source" property.
> > 
> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > ---
> > 
> > Changes in v3: None
> > 
> >  Documentation/devicetree/bindings/spi/spi-bus.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
> > index 1f6e86f..0fa1ccf 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-bus.txt
> > +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt
> > @@ -77,6 +77,7 @@ All slave nodes can contain the following optional properties:
> >  		    Defaults to 1 if not present.
> >  - spi-rx-delay-us - Microsecond delay after a read transfer.
> >  - spi-tx-delay-us - Microsecond delay after a write transfer.
> > +- wakeup-source   - Device can be used as a wakeup source.
> 
> wakeup-source is valid for any device with an interrupts property 
> already, so I don't think this is necessary.

Do you mean it is not necessary on SPI level or not necessary at all? Or
you disagree with wording? Because we do need a way to say that on given
platform the device is supposed to be configured as a wakeup source.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v3 0/6] Report wakeup events in cros_ec_keyb and make cros-ec-spi wakeup optional Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 6/6] ARM: dts: cros-ec-keyboard: enable as wakeup source Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Rob Herring <robh@kernel.org> - 2017-06-26 18:10 +0200
      Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-26 18:50 +0200
        Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional  property jeffy <jeffy.chen@rock-chips.com> - 2017-06-27 04:10 +0200
          Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Rob Herring <robh@kernel.org> - 2017-06-30 16:50 +0200
  [RFC PATCH v3 5/6] input: cros_ec_keyb: report wakeup events Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-21 12:50 +0200
      Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi  devices Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-21 18:50 +0200
        Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi  devices jeffy <jeffy.chen@rock-chips.com> - 2017-06-22 04:40 +0200
  [RFC PATCH v3 1/6] spi: core: add support for wakeup-source dts property Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 1/6] spi: core: add support for wakeup-source dts  property Mark Brown <broonie@kernel.org> - 2017-06-21 13:00 +0200

csiph-web