Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices
Date	2017-06-22 04:40 +0200
Message-ID	<tV0ch-6LK-11@gated-at.bofh.it> (permalink)
References	<tUKKd-4KQ-3@gated-at.bofh.it> <tUKKe-4KQ-29@gated-at.bofh.it> <tULmV-4Zi-11@gated-at.bofh.it> <tUQZk-aB-31@gated-at.bofh.it> <tUQZk-aB-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof,

thanx for noting that, will add it to next version :)


On 06/21/2017 11:36 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 21, 2017 at 11:33:29PM +0800, jeffy wrote:
>> Hi Krzysztof,
>>
>> thanx for your comment.
>>
>> On 06/21/2017 06:45 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Jun 21, 2017 at 12:01 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>>>> We used to enable wakeup for cros-ec-spi devices unconditionally.
>>>> Now we are using the more generic wakeup-source property to enable it.
>>>
>>> Using wakeup-source property is still enabling this unconditionally.
>>> What  do you exactly mean here?
>> i mean the wakeup-source is an optional property, we can disable wakeup by
>> not adding it.
>
> Maybe mention this in commit msg? This removes any confusion. "Till now
> the driver always enabled wakeup but now it supports wakeup property so
> add it to keep same functionality."
>
> Best regards,
> Krzysztof
>
>
>
>

Thread

[RFC PATCH v3 0/6] Report wakeup events in cros_ec_keyb and make cros-ec-spi wakeup optional Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 6/6] ARM: dts: cros-ec-keyboard: enable as wakeup source Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional property Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Rob Herring <robh@kernel.org> - 2017-06-26 18:10 +0200
      Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-06-26 18:50 +0200
        Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source optional  property jeffy <jeffy.chen@rock-chips.com> - 2017-06-27 04:10 +0200
          Re: [RFC PATCH v3 2/6] dt-bindings: spi/core: add wakeup-source  optional property Rob Herring <robh@kernel.org> - 2017-06-30 16:50 +0200
  [RFC PATCH v3 5/6] input: cros_ec_keyb: report wakeup events Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
  [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi devices Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-21 12:50 +0200
      Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi  devices Krzysztof Kozlowski <krzk@kernel.org> - 2017-06-21 18:50 +0200
        Re: [RFC PATCH v3 3/6] ARM/arm64: dts: enable wakeup for cros-ec-spi  devices jeffy <jeffy.chen@rock-chips.com> - 2017-06-22 04:40 +0200
  [RFC PATCH v3 1/6] spi: core: add support for wakeup-source dts property Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-21 12:10 +0200
    Re: [RFC PATCH v3 1/6] spi: core: add support for wakeup-source dts  property Mark Brown <broonie@kernel.org> - 2017-06-21 13:00 +0200

csiph-web