Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Matthias Schiffer <mschiffer@universe-factory.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration
Date	Fri, 23 Jun 2017 12:20:01 +0200
Message-ID	<tVtQZ-Rn-9@gated-at.bofh.it> (permalink)
References	<tTZUZ-8vX-3@gated-at.bofh.it> <tTZUZ-8vX-11@gated-at.bofh.it> <tVsBA-8nM-23@gated-at.bofh.it>
X-Original-To	Jiri Benc <jbenc@redhat.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kX56mNhitti5XKHKoPEP4U8CnxwXjNWHG"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	89
Organization	linux.* mail to news gateway
X-Original-Cc	davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 23 Jun 2017 12:13:46 +0200
X-Original-Message-ID	<113c3fe1-f490-d92d-2b4a-69b7115d8115@universe-factory.net>
X-Original-References	<cover.1497825555.git.mschiffer@universe-factory.net> <6e2c8bb77be42834f1da5a3ca79f5e455574a136.1497825555.git.mschiffer@universe-factory.net> <20170623105220.18561f34@griffin>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1673455

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 06/23/2017 10:52 AM, Jiri Benc wrote:
> This patchset looks good overall (would send my Acked-by for most of
> this but I'm late).
> 
> On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
>> Log messages in these
>> functions are removed, as it is generally unexpected to find error output
>> for netlink requests in the kernel log. Userspace should be able to handle
>> errors based on the error codes returned via netlink just fine.
> 
> However, this is not really true. It's impossible to find out what went
> wrong when you use e.g. iproute2 to configure a vxlan link.
> 
> We really need to convert the kernel log messages to the extended
> netlink errors. Since you removed them prematurely, could you please
> work on that?
> 
> Thanks,
> 
>  Jiri
> 

I was told the extended netlink error facilities were not ready yet, has
that changed since the last release?

Off the top of my head, I can't think of any other setting I can do with
iproute2 that will write its errors in the kernel log; but there are quite
a lot settings that will just return a very unspecific error code. Isn't it
more common for the userspace tool to handle diagnostics in such cases?

Anyways, I will gladly work on improving the error handling if someone can
give me a pointer how these extended netlink errors are used.

Matthias

Thread

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Jiri Benc <jbenc@redhat.com> - 2017-06-23 11:00 +0200
  Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-23 12:20 +0200
    Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Johannes Berg <johannes@sipsolutions.net> - 2017-06-23 12:30 +0200
      Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-23 14:10 +0200
        Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Johannes Berg <johannes@sipsolutions.net> - 2017-06-23 15:40 +0200

csiph-web