Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673393

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

Show all headers | View raw

This patchset looks good overall (would send my Acked-by for most of
this but I'm late).

On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
> Log messages in these
> functions are removed, as it is generally unexpected to find error output
> for netlink requests in the kernel log. Userspace should be able to handle
> errors based on the error codes returned via netlink just fine.

However, this is not really true. It's impossible to find out what went
wrong when you use e.g. iproute2 to configure a vxlan link.

We really need to convert the kernel log messages to the extended
netlink errors. Since you removed them prematurely, could you please
work on that?

Thanks,

 Jiri

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Jiri Benc <jbenc@redhat.com> - 2017-06-23 11:00 +0200
  Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-23 12:20 +0200
    Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Johannes Berg <johannes@sipsolutions.net> - 2017-06-23 12:30 +0200
      Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-23 14:10 +0200
        Re: [PATCH net-next v3 1/6] vxlan: refactor verification and  application of configuration Johannes Berg <johannes@sipsolutions.net> - 2017-06-23 15:40 +0200

csiph-web